This repository was archived by the owner on Apr 30, 2020. It is now read-only.
Fix tests #76
Merged
Fix tests #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert to pathlib in the process and shake until it passes
hroncok
commented
Dec 13, 2018
| artifact = artifactsdir / 'output.log' | ||
|
|
||
| artifactsdir.mkdir(parents=True, exist_ok=True) | ||
| resultsdir.mkdir(parents=True, exist_ok=True) |
Member
Author
There was a problem hiding this comment.
Those two mkdirs were needed.
cc @kparal and @frantisekz - previously it worked without this
hroncok
commented
Dec 13, 2018
| pycallgraph = fixtures_factory('_pycallgraph') | ||
|
|
||
| _ttystatus = fixtures_factory('python-ttystatus-0.34-7.fc29') | ||
| ttystatus = fixtures_factory('_ttystatus') |
Member
Author
There was a problem hiding this comment.
Note that I'd rather replace pycallgraph with another package, but i couldn't find anything that would fit for both usecases pycallgraph had.
We don't need any modular builds (yet?) and this saves the metadata pull.
Member
|
The changes look OK to me, but I'm not very familiar with the code. |
irushchyshyn
approved these changes
Dec 18, 2018
| if '[' in nodeid: | ||
| parameters = nodeid.rsplit('[')[-1].replace(']', '') | ||
| return parameters.split('-')[0] | ||
| return None |
Collaborator
There was a problem hiding this comment.
I believe the last return is redundunt.
Member
Author
|
Thanks @irushchyshyn, @encukou! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.